Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Symfony 7.1 and leverage its features #334

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Adds Symfony 7.1 to CI;
  • Uses ramsey/composer-install gh action to install dependencies;
  • Uses new DateTimeNormalizer::CAST_KEY when available to serialize datetimes as timestamps;

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas added skip-changelog The PR will not appear in the release changelogs maintenance Anything related to maintenance (CI, tests, refactoring...) labels Jun 13, 2024
@norkunas norkunas force-pushed the sf71 branch 17 times, most recently from ae6a63f to b634c58 Compare June 14, 2024 03:39
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (7e7cbc6) to head (021fb25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #334      +/-   ##
============================================
+ Coverage     86.91%   86.99%   +0.07%     
  Complexity        1        1              
============================================
  Files            19       19              
  Lines           818      823       +5     
============================================
+ Hits            711      716       +5     
  Misses          107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas
Copy link
Collaborator Author

Side effect from #322 was that removing .* from sf-version, it uses directly the defined version instead of highest, so for 5.4 it uses 5.4.0 instead of 5.4.40

@norkunas norkunas force-pushed the sf71 branch 6 times, most recently from 7d5148c to 16f1757 Compare June 25, 2024 12:18
@norkunas
Copy link
Collaborator Author

bors merge

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@curquiza
Copy link
Member

bors merge-

@curquiza
Copy link
Member

bors merge

@curquiza
Copy link
Member

Issue with bors again, merging by hand

@curquiza curquiza merged commit 82e2943 into meilisearch:main Jun 25, 2024
13 of 14 checks passed
@curquiza curquiza removed the skip-changelog The PR will not appear in the release changelogs label Jun 25, 2024
@norkunas norkunas deleted the sf71 branch June 26, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants